fix: enforce strong secrets for AUTH and JWT in configuration#471
Merged
alanrsoares merged 2 commits intomainfrom Nov 17, 2025
Merged
fix: enforce strong secrets for AUTH and JWT in configuration#471alanrsoares merged 2 commits intomainfrom
alanrsoares merged 2 commits intomainfrom
Conversation
Updated the configuration logic to throw errors if the AUTH and JWT environment variables are not set or are using default values. This ensures that strong secrets are provided for secure application operation.
✅ Deploy Preview for dither-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mazzy89
suggested changes
Nov 12, 2025
mazzy89
left a comment
mazzy89
left a comment
There was a problem hiding this comment.
It is required to fix docker compose otherwise apps locally won't start
mazzy89
approved these changes
Nov 17, 2025
github-project-automation
bot
moved this from Ready to Build
to Launch Prep
in Dither Community Board
github-project-automation
bot
moved this from Launch Prep
to Done
in Dither Community Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail Fast on Missing Secrets (#389, #387)
Part of Epic #388: Outstanding Audit Items
Issues Fixed
'default', causing silent retry loopsSolution
Fail fast validation at startup for both secrets, matching
PG_URIpattern.Changes
packages/reader-main/src/config/index.ts: Fail fast on missing/invalidAUTHpackages/api-main/src/config.ts: Fail fast on missingJWT, remove auto-generationImpact
Before: Silent retries, session invalidation on restart
After: Immediate failure with clear errors at startup